Call MaybeReleaseBuffers when AmqpException is thrown #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleAmqpClient doesn't call MaybeReleaseBuffers when it throws an AmqpException, which is ok if it happens infrequently as the memory will get released the next successful API calls MaybeReleaseBuffers. However, in the case where the API is continually called in a way that causes channel.close methods to be returned (e.g., exchange gets destroyed and the client continues to publish to the exchange that doens't exist), the memory used by each return method frame is never released. This fixes that. This is a fix for Issue #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleAmqpClient doesn't call MaybeReleaseBuffers when it throws
an AmqpException, which is ok if it happens infrequently as
the memory will get released the next successful API calls
MaybeReleaseBuffers. However, in the case where the API is
continually called in a way that causes channel.close methods to be
returned (e.g., exchange gets destroyed and the client continues
to publish to the exchange that doens't exist), the memory
used by each return method frame is never released.
This fixes that.
This is a fix for Issue #28