Don't escape semicolons after drive letters #63
Conversation
The RFC says that semicolons may be used for special purposes in path parts of urls, and in this case no escaping is allowed. And this is consistent with Microsoft samples. See haskell/haskell-ide-engine#329 for discussion See autozimu/LanguageClient-neovim#144 for normative references and Microsoft examples of typical errors in URLs
|
@alanz ping :) |
|
@wz1000 is currently reworking things, that includes bringing in a different filepath in ghc-mod. Once that is done we can confirm whether this issue still exists. |
|
And raeading more closely, this is not the issue I thought it was :( |
|
So what are we going to do? Correct per specification url escaping is a good thing as we deal with them all the time. |
|
We will fix it, I read the backscroll and got confused about what precisely it was. But I first want the @wz1000 async stuff to land, as it touches a lot of the repos involved in this one, and I don't wont a tricky merge again. The best will be to use an actual URI type, so that escaping gets handled as per the spec. |
|
Oh, I see. We all hate tricky merges :)
Sure. This was sort of a hot fix as many people reported the problem. BTW in this case a totally correct solution is tricky. The specification says that |
|
@alanz Can we merge it now? @soylens at haskell/haskell-ide-engine#396 seems to report that |
|
Have you not been experiencing the |
|
I haven't tested hie on windows after the commit yet. |
Part of the work towards #63. The session will now keep track of the capabilities that are registered and unregister them when requests come in from the server. openDoc' has been removed and replaced with createDoc. createDoc will send out workspace/didChangeWatchedFiles notifications whenever the server registers for it.
Part of the work towards bubba/lsp-test/#63. The session will now keep track of the capabilities that are registered and unregister them when requests come in from the server. openDoc' has been removed and replaced with createDoc. createDoc will send out workspace/didChangeWatchedFiles notifications whenever the server registers for it.
The RFC says that semicolons may be used for special purposes in path parts of urls, and in this case no escaping is allowed. And this is consistent with Microsoft samples.
See haskell/haskell-ide-engine#329 for discussion
See autozimu/LanguageClient-neovim#144 for normative references and Microsoft examples of typical errors in URLs