Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Resolv #60

Closed
alaz opened this issue Feb 20, 2022 · 0 comments · Fixed by #61
Closed

Mock Resolv #60

alaz opened this issue Feb 20, 2022 · 0 comments · Fixed by #61

Comments

@alaz
Copy link
Owner

alaz commented Feb 20, 2022

Petalbot resolution is not reliable.
alaz added a commit that referenced this issue Feb 21, 2022
@alaz
🚨 mock DNS in tests [closes #60]
bb09c63 
Relying on the environment in tests is not reliable, especially when
some crawlers implement frequent changes to their DNS.
@alaz alaz linked a pull request Feb 21, 2022 that will close this issue
Mock DNS in tests #61
Merged
@alaz alaz closed this as completed in #61 Feb 21, 2022
alaz added a commit that referenced this issue Feb 21, 2022
@alaz
🚨 mock DNS in tests [closes #60] (#61)
b879ab8 
Relying on the environment in tests is not reliable, especially when
some crawlers implement frequent changes to their DNS.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mock DNS in tests alaz/legitbot
1 participant
@alaz