feat(enharmonic): implement items getter

albertms10 · Apr 7, 2023 · 6cf9ecd · 6cf9ecd
1 parent 1ada113
commit 6cf9ecd
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 20 deletions.
diff --git a/lib/src/classes/enharmonic.dart b/lib/src/classes/enharmonic.dart
@@ -15,8 +15,7 @@ abstract class Enharmonic<T extends MusicItem>
         );
 
   /// Returns the items sharing the same [semitones].
-  // TODO(albertms10): implement method.
-  Set<T> get items => {};
+  Set<T> get items;
 
   /// Returns a transposed [Enharmonic] by [semitones] from this [Enharmonic].
   @override

diff --git a/lib/src/classes/enharmonic_interval.dart b/lib/src/classes/enharmonic_interval.dart
@@ -3,8 +3,8 @@ part of '../../music_notes.dart';
 class EnharmonicInterval extends Enharmonic<Interval> {
   const EnharmonicInterval(super.semitones);
 
-  /// Returns the [EnharmonicInterval] from [semitones].
-  static Set<Interval> _fromSemitones(int semitones) {
+  @override
+  Set<Interval> get items {
     final interval = IntervalsValues.fromSemitones(semitones);
 
     if (interval != null) {

diff --git a/lib/src/classes/enharmonic_note.dart b/lib/src/classes/enharmonic_note.dart
@@ -16,8 +16,8 @@ class EnharmonicNote extends Enharmonic<Note> {
   static const aSharp = EnharmonicNote(11);
   static const b = EnharmonicNote(12);
 
-  /// Returns the [EnharmonicNote] from [semitones].
-  static Set<Note> _fromSemitones(int semitones) {
+  @override
+  Set<Note> get items {
     final note = NotesValues.fromValue(semitones);
 
     if (note != null) {

diff --git a/test/enharmonic_interval_test.dart b/test/enharmonic_interval_test.dart
@@ -16,18 +16,4 @@ void main() {
       equals(const Interval(Intervals.fifth, Qualities.diminished)),
     );
   });
-
-  test('Items are correct', () {
-    expect(const EnharmonicInterval(6).items, {
-      const Interval(Intervals.fourth, Qualities.augmented),
-      const Interval(Intervals.fifth, Qualities.diminished),
-    });
-    expect(const EnharmonicInterval(4).items, {
-      const Interval(Intervals.third, Qualities.major),
-      const Interval(Intervals.fourth, Qualities.diminished),
-    });
-    expect(const EnharmonicInterval(2).items, {
-      const Interval(Intervals.second, Qualities.major),
-    });
-  });
 }