Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(note): move fifths distance functions to class methods #19

Merged
merged 3 commits into from
Apr 8, 2023
Merged

refactor(note): move fifths distance functions to class methods #19

merged 3 commits into from
Apr 8, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added refactor The code needs to be refactored test The code needs to implement tests labels Apr 8, 2023
@albertms10 albertms10 self-assigned this Apr 8, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4646104940

  • 13 of 18 (72.22%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+21.2%) to 62.153%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/tonality/tonality.dart 0 5 0.0%
Totals Coverage Status
Change from base Build 4645990820: 21.2%
Covered Lines: 179
Relevant Lines: 288
💛 - Coveralls

@albertms10 albertms10 merged commit eee900c into main Apr 8, 2023
@albertms10 albertms10 deleted the refactor/move-fifths-distance-function-to-class-methods branch April 8, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertms10 @coveralls