Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(key_signature): add test cases for tonalities getter #26

Merged
merged 5 commits into from
Apr 9, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests labels Apr 9, 2023
@albertms10 albertms10 self-assigned this Apr 9, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4647911631

  • 10 of 12 (83.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.6%) to 77.474%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/tonality/key_signature.dart 1 3 33.33%
Totals Coverage Status
Change from base Build 4647867231: 9.6%
Covered Lines: 227
Relevant Lines: 293

💛 - Coveralls

@albertms10 albertms10 merged commit 3bca3a7 into main Apr 9, 2023
@albertms10 albertms10 deleted the test/add-test-cases-for-key-signatures-tonalities branch April 9, 2023 00:47
albertms10 added a commit that referenced this pull request Apr 14, 2023
albertms10 added a commit that referenced this pull request Apr 14, 2023
* fix(note): simplify `fromRawAccidentals` accidental increment

Fixes failing tests introduced in #26

* test(key_signature): bring TODO comment back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor The code needs to be refactored test The code needs to implement tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants