Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tonality): improve compareTo sorting by note and mode #37

Merged
merged 1 commit into from
Apr 9, 2023
Merged

feat(tonality): improve compareTo sorting by note and mode #37

merged 1 commit into from
Apr 9, 2023

Conversation

albertms10
Copy link
Owner

No description provided.

@albertms10 albertms10 added enhancement New feature or request test The code needs to implement tests labels Apr 9, 2023
@albertms10 albertms10 self-assigned this Apr 9, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4652954250

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 11 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-3.6%) to 88.235%
Files with Coverage Reduction New Missed Lines %
lib/src/interval/interval.dart 1 93.33%
lib/src/interval/qualities.dart 2 50.0%
lib/src/note/note.dart 4 92.45%
lib/src/tonality/tonality.dart 4 50.0%
Totals Coverage Status
Change from base Build 4652785556: -3.6%
Covered Lines: 270
Relevant Lines: 306
💛 - Coveralls

@albertms10 albertms10 merged commit 485284c into main Apr 9, 2023
@albertms10 albertms10 deleted the feat/improve-tonality-compare-to branch April 9, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@albertms10 albertms10

Labels
enhancement New feature or request test The code needs to implement tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertms10 @coveralls