Merge pull request rails-lambda#170 from rails-lambda/PercentInPath

Safely Pass Percent Symbols in Paths

CHANGELOG.md

@@ -2,6 +2,12 @@
 
 See this http://keepachangelog.com link for information on how we want this documented formatted.
 
+## v5.2.0
+
+### Fixed
+
+- Safely Pass Percent Symbols in Paths Fixes #170
+
 ## v5.1.0
 
 ### Added

Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    lamby (5.1.0)
+    lamby (5.2.0)
       lambda-console-ruby
       rack
 

lib/lamby/rack_http.rb

@@ -78,6 +78,7 @@ def cookies
     def path_info
       stage = event.dig('requestContext', 'stage')
       spath = event.dig('requestContext', 'http', 'path') || event.dig('requestContext', 'path')
+      spath = event['rawPath'] if spath != event['rawPath'] && !payload_version_one?
       spath.sub /\A\/#{stage}/, ''
     end
 

lib/lamby/version.rb

@@ -1,3 +1,3 @@
 module Lamby
-  VERSION = '5.1.0'
+  VERSION = '5.2.0'
 end

test/dummy_app/app/controllers/application_controller.rb

@@ -26,6 +26,10 @@ def exception
     raise 'hell'
   end
 
+  def percent
+    render
+  end
+
   def cooks
     cookies['1'] = '1'
     cookies['2'] = '2'

test/dummy_app/app/views/application/percent.html.erb

@@ -0,0 +1,2 @@
+Params: <%= params[:path] %>
+Request Path: <%= request.path %>

test/dummy_app/config/routes.rb

@@ -4,6 +4,7 @@
   post 'login', to: 'application#login'
   delete 'logout', to: 'application#logout'
   get 'exception', to: 'application#exception'
+  get 'percent/*path', to: 'application#percent'
   get 'cooks', to: 'application#cooks'
   get 'redirect_test', to: redirect('/')
 end

test/handler_test.rb

@@ -86,6 +86,17 @@ class HandlerTest < LambySpec
       expect(result[:body]).must_match %r{We're sorry, but something went wrong.}
       expect(result[:body]).must_match %r{This file lives in public/500.html}
     end
+
+    it 'get - percent' do
+      event = TestHelpers::Events::HttpV2.create(
+        'rawPath' => '/production/percent/dwef782jkif%3d',
+        'requestContext' => { 'http' => {'path' => '/production/percent/dwef782jkif='} }
+      )
+      result = Lamby.handler app, event, context, rack: :http
+      expect(result[:statusCode]).must_equal 200
+      expect(result[:body]).must_match %r{Params: dwef782jkif=}
+      expect(result[:body]).must_match %r{Request Path: /percent/dwef782jkif%3}
+    end
 
   end