Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move GasOverheads to chain spec (or hardcode) #638

Closed
dancoombs opened this issue Mar 13, 2024 · 2 comments · Fixed by #703 or #750
Closed

Move GasOverheads to chain spec (or hardcode) #638

dancoombs opened this issue Mar 13, 2024 · 2 comments · Fixed by #703 or #750
Assignees
@dancoombs
Labels
enhancement New feature or request

Comments

@dancoombs
Copy link
Collaborator

Describe the feature
GasOverheads is currently only used in its default form without any way to configure. We should either move these to hardcoded constants or move this into chain spec.
@dancoombs dancoombs added the enhancement New feature or request label Mar 13, 2024
@dancoombs dancoombs added this to the v0.2 milestone Mar 13, 2024
@dancoombs dancoombs mentioned this issue Mar 13, 2024
Merged
@dancoombs dancoombs self-assigned this Mar 22, 2024
@dancoombs dancoombs modified the milestones: v0.2, v0.3 Apr 12, 2024
@dancoombs
Copy link
Collaborator Author

Decided against doing this as we need different overheads defined for each EP. If we find chains with different gas calculations we can move this to chain spec.

@dancoombs dancoombs mentioned this issue May 2, 2024
Merged
@dancoombs dancoombs modified the milestones: v0.3, v0.2 May 2, 2024
@dancoombs dancoombs reopened this Jul 1, 2024
@dancoombs
Copy link
Collaborator Author

Avax had different gas overheads, reopening.

@dancoombs dancoombs removed this from the v0.2 milestone Jul 1, 2024
dancoombs added a commit that referenced this issue Jul 1, 2024
@dancoombs
feat: add support for avax chains
74f7941 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
@dancoombs dancoombs mentioned this issue Jul 1, 2024
Merged
dancoombs added a commit that referenced this issue Jul 1, 2024
@dancoombs
feat: add support for avax chains
90835a6 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
dancoombs added a commit that referenced this issue Jul 2, 2024
@dancoombs
feat: add support for avax chains
032d5c1 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
dancoombs added a commit that referenced this issue Jul 8, 2024
@dancoombs
feat: add support for avax chains
6ed657e 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
dancoombs added a commit that referenced this issue Jul 8, 2024
@dancoombs
feat: add support for avax chains
20ac91f 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
dancoombs added a commit that referenced this issue Jul 8, 2024
@dancoombs
feat: add support for avax chains
3e37638 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
dancoombs added a commit that referenced this issue Jul 8, 2024
@dancoombs
feat: add support for avax chains
a88a4c7 
- Add gas overheads to chain spec (#638)
- Allow for retries in chain sync
- Add avax and avas fuji chain specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancoombs dancoombs

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
1 participant
@dancoombs