Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

GC: Item Attachment Not Supported #2353

Closed
1 task done
dadams39 opened this issue Feb 1, 2023 · 3 comments · Fixed by #2355
Closed
1 task done

GC: Item Attachment Not Supported #2353

dadams39 opened this issue Feb 1, 2023 · 3 comments · Fixed by #2355
Assignees
@dadams39
Labels
bug Something isn't working restore

Comments

@dadams39
Copy link
Contributor

dadams39 commented Feb 1, 2023 •
edited
Loading

Restoring an email with an Item Attachment causes failure. Single Value Property cannot be added to the attachment. Indicates that portions of the attachment were not downloaded and cannot be uploaded with the property Item.

* uploading attachment for message <messageID> : ErrorInvalidProperty The property 'Item' is required when creating the entity.: error status code received from the API
<originalMessageID>: failed to upload RestoreExchangeObject: exchange-email: 1 error occurred:

* uploading attachment for message <messageID> : ErrorInvalidProperty The property 'Item' is required when creating the entity.: err

Steps:
@dadams39 dadams39 self-assigned this Feb 1, 2023
@dadams39 dadams39 added the bug Something isn't working label Feb 1, 2023
@ashmrtn ashmrtn added the restore label Feb 1, 2023
dadams39 added a commit that referenced this issue Feb 1, 2023
@dadams39
Update to /connector/exchange/restore_test.go
52572f9 
Adds test case for edge case that reproduces error found in Issue #2353.
@dadams39 dadams39 mentioned this issue Feb 1, 2023
Merged
3 tasks
@dadams39 dadams39 linked a pull request Feb 1, 2023 that will close this issue
GC: Restore: event.item attachment support #2355
Merged
3 tasks
@dadams39
Copy link
Contributor Author

dadams39 commented Feb 1, 2023

Verified all items can attachment items complete without failure for extended options within a7c56a7

@dadams39
Copy link
Contributor Author

dadams39 commented Feb 1, 2023

New Error

        * errors prevented the operation from processing                                                                                                                                                                                                                                                                                     
        * restoring service data: 1 error occurred:                                                                                                                                                                                                                                                                                          
        * <messageID>=: failed to upload RestoreExchangeObject: exchange-email: 1 error occurred:                                                                                                
        * uploading attachment for message<messageID>=: :  ErrorInvalidPropertySet Set action is invalid for property.: error status code received from the API

@dadams39 dadams39 mentioned this issue Feb 1, 2023
Merged
3 tasks
dadams39 added a commit that referenced this issue Feb 1, 2023
@dadams39
Updates to /connector/exchange/attachment.go
a6d5f71 
Patch for . Will log that item attachments, a specific type, are not uploaded at present. Issue #2353 will include removing this patch.
@dadams39 dadams39 mentioned this issue Feb 1, 2023
Merged
3 tasks
aviator-app bot pushed a commit that referenced this issue Feb 1, 2023
GC: Backup: ItemAttachment Complete (#2358)
93e8b67 
## Description
Bug fix: Ensures that `item.Attachment` content is completely backed up.

- Exchange 
Changes affect the behavior of Mail and Events. Downloads can be potentially bigger if the user have these types of attachments.

- `item.Attachments` are specific to Outlook objects such as `Events` or `Messages` are included as an attachment rather than inline.  

<!-- Insert PR description-->

## Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included

## Type of change
- [x] 🐛 Bugfix


## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* related to  #2353<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
aviator-app bot pushed a commit that referenced this issue Feb 1, 2023
GC: Restore: Disable Item.Attachment Restore (#2359)
46d584e 
## Description

`Item.Attachments` have unique properties that require transformation to be uploaded into the M365 system. All objects of this type are temporarily prevented from uploading via this patch. As Issue #2353 is addressed, there will be more coverage for the various types of item attachments. 


<!-- Insert PR description-->

## Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included

## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
*related to  #2353<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
@dadams39
Copy link
Contributor Author

dadams39 commented Feb 2, 2023 •
edited
Loading

Escalated to Q&A for ItemAttachments that are based on event objects. These can be the more complex of OutlookItemable objects. In the case of ItemAttachment-Event, the attachment cannot currently be uploaded after sanitizing the data.

This was referenced Feb 2, 2023
Merged
Closed
aviator-app bot pushed a commit that referenced this issue Feb 2, 2023
GC: Logging: Expand ItemAttachment object details for coverage (#2366)
844dcae 
## Description
Updates within /internal/connector/exchange package. Adds helper function for displaying the internal object item type that is included as an attachment. This will help overall with supporting additional `ItemAttachment` objects. 
<!-- Insert PR description-->

## Does this PR need a docs update or release note?
- [x] ⛔ No 

## Type of change

<!--- Please check the type of change your PR introduces: --->

- [x] 🧹 Tech Debt/Cleanup

## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
* related to #2353<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] 💪 Manual
aviator-app bot pushed a commit that referenced this issue Feb 3, 2023
GC: Restore: event.item attachment support (#2355)
35d8942 
## Description
`Item.Attachments` of OdataType `Event` require special transformations prior to being uploaded. 

## Does this PR need a docs update or release note?

- [x] ✅ Yes, it's included


## Type of change

<!--- Please check the type of change your PR introduces: --->
- [x] 🌻 Feature


## Issue(s)

<!-- Can reference multiple issues. Use one of the following "magic words" - "closes, fixes" to auto-close the Github issue. -->
*closes #2353<issue>

## Test Plan

<!-- How will this be tested prior to merging.-->
- [x] ⚡ Unit test
@dadams39 dadams39 mentioned this issue Feb 7, 2023
Open
6 tasks
@ryanfkeepers ryanfkeepers mentioned this issue May 24, 2023
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dadams39 dadams39

Labels
bug Something isn't working restore
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GC: Restore: event.item attachment support alcionai/corso
2 participants
@ashmrtn @dadams39