-
Notifications
You must be signed in to change notification settings - Fork 39
Return stats directly from restore function #4713
Conversation
Current Aviator status
This PR was merged using Aviator. See the real-time status of this PR on the Aviator webapp. Use the Aviator Chrome Extension to see the status of your PR within GitHub.
|
d987de4
to
b0bf1dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I'm in favor of the pattern here, the intent is to replace this with the count.Bus anyway. What's your preference: keep this change and undo it later? Or drop it and we'll get around to it with the count.Bus update?
Let's keep this for now as it makes switching to service-level handlers much simpler. We can rearrange/remove this after that point |
Instead of returning a status and then waiting on the message just return the restore stats directly. The status getter was only setup to wait for one item anyway and was setup to wait after the entire restore operation already completed (at end of m365/restore.go:ConsumeRestoreCollections())
b0bf1dd
to
d20dd1a
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Rework restore return status so that later PRs will have a smaller diff
Instead of returning a status and then waiting on the message just return the restore stats directly. The status getter was only setup to wait for one item anyway and was setup to wait after the entire restore operation already completed (at end of
m365/restore.go:ConsumeRestoreCollections())
Does this PR need a docs update or release note?
Type of change
Issue(s)
Test Plan