Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

fix mailbox user not found handling #5169

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix mailbox user not found handling #5169

wants to merge 3 commits into from

Conversation

ryanfkeepers
Copy link
Contributor

re-splits the difference between a user not found error and a non-user not found error.

Does this PR need a docs update or release note?

  • ✅ Yes, it's included

Type of change

  • 🐛 Bugfix

Issue(s)

Test Plan

  • ⚡ Unit test
  • 💚 E2E

@ryanfkeepers ryanfkeepers added bug Something isn't working exchange graph api for changes related to communicating directly with the graph rest api labels Jan 30, 2024
@ryanfkeepers ryanfkeepers self-assigned this Jan 30, 2024
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Jan 30, 2024 •
edited
Loading

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This PR is not ready to merge (currently in state blocked): some required checks failed.

Once the issues are resolved, remove the blocked label and re-queue the pull request. Note that the pull request will be automatically re-queued if it has the mergequeue label.

Pending Status Checks

  • ⏳ Actions-Lint (missing)
  • ⏳ Checkout (missing)
  • ⏳ Precheck / file-change-check (missing)
  • ⏳ Retention-Test-Suite-Trusted (missing)
  • ⏳ Source-Code-Linting (missing)
  • ⏳ 3 other pending tests
See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@ryanfkeepers ryanfkeepers removed the request for review from pandeyabs January 30, 2024 21:44
zackrossman
zackrossman approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@zackrossman zackrossman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but will want a Corso team review as well

src/internal/m365/service/exchange/enabled.go Show resolved Hide resolved
src/pkg/services/m365/api/users.go Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 15, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@aviator-app aviator-app bot added the blocked Upstream item prevents completion label Feb 15, 2024
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Feb 15, 2024

This pull request failed to merge: some CI status(es) failed. Remove the blocked label to re-queue.

Failed CI(s): Test-Suite-Trusted

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zackrossman zackrossman zackrossman approved these changes

@HiteshRepo HiteshRepo HiteshRepo approved these changes

@vkamra vkamra Awaiting requested review from vkamra

@ashmrtn ashmrtn Awaiting requested review from ashmrtn

At least 1 approving review is required to merge this pull request.

Assignees

@ryanfkeepers ryanfkeepers

Labels
blocked Upstream item prevents completion bug Something isn't working exchange graph api for changes related to communicating directly with the graph rest api mergequeue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanfkeepers @HiteshRepo @zackrossman