Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight the line number targeted by the URL anchor #317

Merged
merged 1 commit into from
Dec 31, 2019

Conversation

aleb
Copy link
Contributor

@aleb aleb commented Dec 18, 2019

This currently works only when html.WithClasses(true) is used.
The same colors as for the pre-highlighted lines are used.
Only the line number is highlighted, so difficult to notice, but
better than nothing.

@alecthomas
Copy link
Owner

CI is failing, also screenshot? Seems like a good idea though!

This currently works only when `html.WithClasses(true)` is used.
The same colors as for the pre-highlighted lines are used.
Only the line number is highlighted, so difficult to notice, but
better than nothing.
@aleb
Copy link
Contributor Author

aleb commented Dec 19, 2019

What do you think about moving id="L..." to new span elements wrapping each line? Would allow for more flexibility, and for the entire line to be highlighted.

@aleb
Copy link
Contributor Author

aleb commented Dec 19, 2019

BTW, I did not get any email about the travis failure.

@alecthomas alecthomas merged commit 19d5ee6 into alecthomas:master Dec 31, 2019
@alecthomas
Copy link
Owner

Thanks!

@alecthomas
Copy link
Owner

What do you think about moving id="L..." to new span elements wrapping each line? Would allow for more flexibility, and for the entire line to be highlighted.

Seems reasonable to me, presumably that wouldn't break anything in Hugo @bep ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants