Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BashSession lexer #551

Merged

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Sep 19, 2021

A basic bash-session lexer, addressing #137.

The idea was to start simple (cover 80% of use cases) and evolve the lexer as needed -- I'd rather have this than no console lexer at all 😄.

/cc @nate-double-u

@alecthomas
Copy link
Owner

The idea was to start simple (cover 80% of use cases) and evolve the lexer as needed -- I'd rather have this than no console lexer at all 😄.

+1 to that, good start thanks :)

@alecthomas alecthomas merged commit 7259f5b into alecthomas:master Sep 19, 2021
@chalin chalin deleted the chalin-shellsession-lexer-2021-09-18 branch September 19, 2021 12:21
@chalin
Copy link
Contributor Author

chalin commented Sep 19, 2021

Great!

@alecthomas: might you be making a release soon? I'd love to start using this basic lexer in Hugo, and get the fix to #507 so that we can close gohugoio/hugo#8532.

anthonyfok added a commit to anthonyfok/glamour that referenced this pull request Nov 29, 2021
chroma v0.9.4 adds "bash-session" (a.k.a. "console") lexer
(from alecthomas/chroma#551),
hence testdata/readme.test needs to be regenerated.
anthonyfok added a commit to anthonyfok/glamour that referenced this pull request Nov 29, 2021
chroma v0.9.4 adds "bash-session" (a.k.a. "console") lexer
(from alecthomas/chroma#551) which testdata/readme.markdown.in
happens to use, and hence the need to regenerate testdata/readme.test.
muesli pushed a commit to charmbracelet/glamour that referenced this pull request Nov 29, 2021
chroma v0.9.4 adds "bash-session" (a.k.a. "console") lexer
(from alecthomas/chroma#551) which testdata/readme.markdown.in
happens to use, and hence the need to regenerate testdata/readme.test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants