Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable use of TreeGrid using HierarchicalDataProvider #64

Merged
merged 4 commits into from
Apr 17, 2020

Conversation

jflamy
Copy link
Contributor

@jflamy jflamy commented Mar 15, 2020

Generic is bound to Void, which prevents use of TreeDataProvider as in the following -- which works fine with the proposed one-character fix.

        crudGrid.setCrudListener(new LazyCrudListener<TeamTreeItem>() {
            @Override
            public DataProvider<TeamTreeItem, ?> getDataProvider() {
                return new TreeDataProvider<TeamTreeItem>(new TeamTreeData());
            }
        });

@jflamy
Copy link
Contributor Author

jflamy commented Mar 15, 2020

Only the March 15 commit is relevant (one line change) the other commits are me catching up with your code base. I have not yet mastered the art of creating clean requests I'm afraid.

@alejandro-du alejandro-du merged commit efb0bb9 into alejandro-du:master Apr 17, 2020
@alejandro-du
Copy link
Owner

Awesome! I'll include the fix in the next release. Thanks a lot!

@alejandro-du alejandro-du mentioned this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants