-
-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@{version} doesn't get resolved in <tagReleaseMessage> #113
Comments
@Wavemaster111188 You can use maven |
@aleksandr-m For annotating tags, I need the released version, not the SNAPSHOT, therefore the issue. |
@Wavemaster111188 Yes. I didn't change the branch so for me it was correct version. Done. |
Awesome! |
@aleksandr-m thank you for releasing the new version! Can you share more about this Wondering if I can use |
@testphreak Currently no. Right now it can be used only in commit/tag messages. Planning to replace it with proper Maven property which can be used that way as you've described. |
Problem
If you use @{version} in a tag it simply isn't applied (instead it shows the plain text "@{version}").
Reason
This is because the properties map is not taken into account for tagging.
The following code is executed in
gitCommit
but not ingitTag
:Solution
The solution would be to add a
gitTag(final String tagName, final String message, boolean gpgSignTag , Map<String, String> map)
method and use the above code in the method.Then in all tagging Mojos, the new method should be used.
I see no downside in this behaviour.
(this is my very first public issue ever so please help me if I'm done something wrong)
The text was updated successfully, but these errors were encountered: