edit Points class #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simple class for points.
rsgalloway
reviewed
May 7, 2019
| def __init__(self, *args, **kwargs): | ||
| super(Points, self).__init__(*args, **kwargs) | ||
|
|
||
| def set_positions(self, *args): |
There was a problem hiding this comment.
Please see Xform.set_scale, https://github.com/alembic/cask/blob/master/cask.py#L1617
This should probably accept both a V3fArray or a list of values, and check the type.
Suggested change
| def set_positions(self, *args): | |
| def set_positions(self, positions): |
rsgalloway
reviewed
May 7, 2019
| # print content | ||
| positions = imath.V3fArray(len(content)) | ||
| ids = imath.IntArray(len(content)) | ||
| for i in range(0, len(content)): |
There was a problem hiding this comment.
You can then enumerate on the positions to get the id,
Suggested change
| for i in range(0, len(content)): | |
| for i, position in enumerate(positions): |
rsgalloway
reviewed
May 7, 2019
|
|
||
| def set_positions(self, *args): | ||
| content = args[0] | ||
| # print content |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simple class for points.