Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for Tezos #21

Merged
merged 30 commits into from
Sep 29, 2022
Merged

Add functionality for Tezos #21

merged 30 commits into from
Sep 29, 2022

Conversation

MHHukiewitz
Copy link
Member

While it is possible to import from private keys and from mnemonics, it is only possible to sign but not to encrypt/decrypt messages.

This is considered bad practice by the Tezos team and would furthermore require substantial implementation effort.

We need to revise the encryption/decryption scheme to not use the same secret key for signing and encryption. For further reading, please refer to: https://libsodium.gitbook.io/doc/quickstart#how-can-i-sign-and-encrypt-using-the-same-key-pair

@MHHukiewitz
Copy link
Member Author

One test will probably fail, due to Tezos not yet being rolled out on CCNs and validation not instantly happening for the client posting a message with the Tezos account.

@MHHukiewitz
Copy link
Member Author

@odesenfans It just recently started failing on the amending of messages. Any idea why?

@hoh
Copy link
Member

hoh commented Sep 6, 2022

@MHHukiewitz what's going on with the 20 commits in this branch ?

@MHHukiewitz
Copy link
Member Author

@hoh I'm trying to determine, why the tests are failing.

If I use http://163.172.70.92:4024 (upstream version of CCN), then the Tezos tests are successful, while a Publish message test fails (probably due to the test CCN being too slow, as with longer timeout the test is successful).

If I use the standard https://api2.aleph.im URL for requests, the Tezos tests fail, even though I believe @odesenfans updated api2 to the newest version with the fixes applied to aleph-pytezos (to recognize ed25519 keys). It seems, like the new version of this python package was not included in the newest build & update.

We may squas the comments after the workflow are successful.

@MHHukiewitz
Copy link
Member Author

@hoh We fixed it now.

Copy link
Member

@BjrInt BjrInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks functional 👌

src/messages/create/signature.ts Show resolved Hide resolved
src/accounts/tezos.ts Outdated Show resolved Hide resolved
src/accounts/tezos.ts Outdated Show resolved Hide resolved
src/messages/create/publish.ts Show resolved Hide resolved
@MHHukiewitz MHHukiewitz assigned BjrInt and unassigned hoh Sep 21, 2022
@BjrInt BjrInt self-requested a review September 26, 2022 12:01
Copy link
Member

@BjrInt BjrInt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I still got to proof test it before merging

@BjrInt
Copy link
Member

BjrInt commented Sep 28, 2022

I get an error when I try to run the toolshed example with the added Tezos dependencies. I cannot generate keypairs for most of the chains. That means that the @taquito packages are not side-effect free.

@BjrInt BjrInt merged commit 9ac4210 into main Sep 29, 2022
@BjrInt BjrInt deleted the account/tezos branch September 29, 2022 09:17
@BjrInt BjrInt mentioned this pull request Sep 29, 2022
Rgascoin pushed a commit that referenced this pull request Oct 3, 2022
add: Tezos chain support

Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl>
Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
Rgascoin pushed a commit that referenced this pull request Oct 3, 2022
add: Tezos chain support

Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl>
Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
Rgascoin pushed a commit that referenced this pull request Oct 3, 2022
add: Tezos chain support

Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl>
Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants