-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality for Tezos #21
Conversation
One test will probably fail, due to Tezos not yet being rolled out on CCNs and validation not instantly happening for the client posting a message with the Tezos account. |
@odesenfans It just recently started failing on the amending of messages. Any idea why? |
@MHHukiewitz what's going on with the 20 commits in this branch ? |
@hoh I'm trying to determine, why the tests are failing. If I use http://163.172.70.92:4024 (upstream version of CCN), then the Tezos tests are successful, while a Publish message test fails (probably due to the test CCN being too slow, as with longer timeout the test is successful). If I use the standard https://api2.aleph.im URL for requests, the Tezos tests fail, even though I believe @odesenfans updated api2 to the newest version with the fixes applied to aleph-pytezos (to recognize ed25519 keys). It seems, like the new version of this python package was not included in the newest build & update. We may squas the comments after the workflow are successful. |
@hoh We fixed it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks functional 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I still got to proof test it before merging
I get an error when I try to run the |
…ssage type was not inline Solution: Make item_content optional and set undefined, if message is not inline
Solution: Reintroduce own GetPublicKey() function
Solution: Added test to show that a blake-2b hash is needed before signing
This reverts commit 78f9673.
…t, if message type was not inline" This reverts commit 32ded32.
…ssage type was not inline Solution: Make item_content optional and set undefined, if message is not inline
Solution: Reintroduce similar to the style of Solana messages
…t by the user of TEZOSAccount; removed non-obligatory BeaconWallet signature test
c6ccdcf
to
6be5463
Compare
add: Tezos chain support Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl> Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
add: Tezos chain support Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl> Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
add: Tezos chain support Co-authored-by: Mike Hukiewitz <m.h.hukiewitz@students.uu.nl> Co-authored-by: Bonjour Internet <BjrInt@users.noreply.github.com>
While it is possible to import from private keys and from mnemonics, it is only possible to sign but not to encrypt/decrypt messages.
This is considered bad practice by the Tezos team and would furthermore require substantial implementation effort.
We need to revise the encryption/decryption scheme to not use the same secret key for signing and encryption. For further reading, please refer to: https://libsodium.gitbook.io/doc/quickstart#how-can-i-sign-and-encrypt-using-the-same-key-pair