Fix: Restarting the NDP Proxy sometimes crashed #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-ndpd-restart-fails
branch
from
6b8d7f4
to
2340926
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 35.25% 35.20% -0.05%
==========================================
Files 53 53
Lines 4862 4880 +18
Branches 577 580 +3
==========================================
+ Hits 1714 1718 +4
- Misses 3127 3141 +14
Partials 21 21 ☔ View full report in Codecov by Sentry. |
This is likely due because it was restarted too quickly. Solution: Wrap the error in a custom class and retry after 5 seconds. This is still a work in progress as a better approach should limit the frequency of restarts instead, for example using an event or queue.
hoh
force-pushed
the
hoh-ndpd-restart-fails
branch
from
2340926
to
71103f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is likely due because it was restarted too quickly.
Solution: Wrap the error in a custom class and retry after 5 seconds.
This is still a work in progress as a better approach should limit the frequency of restarts instead, for example using an event or queue.