Fix: refuse time and pagination parameters for message WS #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #335. |
odesenfans
force-pushed
the
od-messages-use-different-models-for-api-and-ws
branch
from
e19d6a6
to
290f6f2
Compare
odesenfans
force-pushed
the
od-messages-use-different-models-for-api-and-ws
branch
from
290f6f2
to
7e9959b
Compare
Problem: the message websocket could receive "startDate"/"endDate" and pagination parameters. Solution: use a slightly different Pydantic model for the websocket to reject these parameters.
odesenfans
force-pushed
the
od-messages-use-different-models-for-api-and-ws
branch
from
7e9959b
to
ba305d4
Compare
odesenfans
added a commit
to odesenfans/pyaleph
that referenced
this pull request
Oct 14, 2022
Problem: the time filters are ignored in the messages.json endpoint since aleph-im#337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Oct 14, 2022
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Oct 17, 2022
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Oct 27, 2022
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Jan 9, 2023
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Mar 21, 2023
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Mar 21, 2023
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
odesenfans
added a commit
that referenced
this pull request
Apr 24, 2023
Problem: the time filters are ignored in the messages.json endpoint since #337. Solution: reactivate the filtering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: the message websocket could receive "startDate"/"endDate"
and pagination parameters.
Solution: use a slightly different Pydantic model for the websocket
to reject these parameters.