Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support changing the endpoint entirely #15

Closed
jonsterling opened this issue Mar 17, 2015 · 3 comments · Fixed by #16
Closed

support changing the endpoint entirely #15

jonsterling opened this issue Mar 17, 2015 · 3 comments · Fixed by #16

Comments

@jonsterling
Copy link
Contributor

Currently, only specifying a region is possible. We should support specifying a custom endpoint, which could be useful for mocking Kinesis services for test purposes.
@jonsterling
Copy link
Contributor Author

Closing this issue, because I intend to resolve it at the level of aws-general.

@larskuhtz
Copy link
Member

I reopen this issue since once a Custom EndpointDomain EndPointPort constructor is added to Region in aws-general there is still some boilerplate needed in this package. For example here: https://github.com/alephcloud/hs-aws-kinesis/blob/master/src/Aws/Kinesis/Core.hs#L170.

@larskuhtz larskuhtz reopened this Mar 18, 2015
@jonsterling
Copy link
Contributor Author

Oh right, I forgot about that! Thanks for catching it.

@jonsterling jonsterling mentioned this issue Mar 19, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Custom Endpoints alephcloud/hs-aws-kinesis
2 participants
@jonsterling @larskuhtz