LÖVE 11 fixes #589
Merged
LÖVE 11 fixes #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixel art does not need internal scaling
|
Not updating to 11.5 atm due to love2d/love-android#258 as well as likely slow updates to makelove |
move to an older rev, hopefully supporting 11.5a
may be necessary in the future but lua already reliably uses ipairs order for array-like tables, and some objects tables actually aren't array-like so the change may not always be safe. the only safe ipairs-based solution would be to iterate over the entire ipairs, then check if its size was equal to the table size, and if not return pairs. but that's dumb and again, not necessary currently, though may become necessary should lua's promise that the pairs sort order is undetermined ever become true for arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for remaining conversions from isDirectory and fix themDisable letterboxing by defaultFix Android scaling issueFix color-sensitive slope tileset issuesFix color-sensitive debris tileset issuesUpdate game icon to use modern mario paletteFix Luigi hat colors??CNRUnchangeable character colors still??CNRAlso loading with incorrect colors. Affects highly custom characters like Kirby.Text color copying wrong colorspairs issuesDialog text defaults to black instead of whiteCloses #595
Closes #611
Closes #612
Closes #617
Closes #618
Closes #619
Closes #621
Closes #622
Probably closes #606