This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Change option_list to arg_parse and importlib to work with Django > 1.9 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh gosh. I haven't thought about this codebase in close to 10 years, I remember very little about the internals or what ideas I had about the design space. I think I'm just going to archive the whole repo, and I'd encourage you to just run off a fork, I'm in no position to review it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made some minor tweaks to allow this utility to work with modern Django. The arg changes would not be backwards compatible. If that were important, a backwards compatible change could look something like this.
Also @alex you've been known to not appreciate my IDE's spacing changes but my autoformatter did its thing ¯_(ツ)_/¯
Tested w/ Django 3.2 and Python 3.6.1