Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications aren't entirely accurate #109

Closed
connorshea opened this issue Nov 6, 2020 · 3 comments · Fixed by #121
Closed

Notifications aren't entirely accurate #109

connorshea opened this issue Nov 6, 2020 · 3 comments · Fixed by #121

Comments

@connorshea
Copy link

As I said in this comment, the current logic for notifications is imperfect in that they trigger when the site deploys with a change to the HTML rather than a change to the underlying data.

I'm not really sure how we could distinguish the two, honestly. We could hack around it by creating a separate file to track just the data that'd be updated every time the data updates (and then check for updates to that file rather than the generated HTML), or change the commit message when it is/isn't a data update.

@sebsebmc
Copy link
Contributor

sebsebmc commented Nov 6, 2020

We are aware and the author of the notification code is working on it!

@NickHeiner
Copy link

Awesome! If possible, it would be great if it were easier to tell which data was new.

@sebsebmc
Copy link
Contributor

sebsebmc commented Nov 6, 2020

If you so choose, you can look at the text file for lines with *** those are less than 30 minutes old.
https://github.com/alex/nyt-2020-election-scraper/blob/master/battleground-state-changes.txt

I haven't seen any work on making that show up in the HTML yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants