feat(plugin): Allow integrating more complex render solutions #412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: changes renderer plugin to no longer error when renderer
build.target
is not "chrome?" or "es?".Hello Everyone!
I am currently working on an adapter for using full stack sveltekit applications in Electron, and my current plan is to use
electron-vite
coupled with thesveltekit
vite plugin to compile the application.I am currently accomplishing this here using what is essentially a mono repo to build one app and then importing the handler into an express server embedded inside electron and building electron.
My goal is to simplify this using
electron-vite
and have this be one dev and build command that ends in a fully functional electron application.This error is currently blocking this implementation and feels like an unnecessary limitation of the platform.
I have converted the error thrown to a warning message that I think accomplishes the same thing in most instances.
I believe that making this change would allow similar
full-stack
style implementations for other platforms that include a server-side component and can be compiled to node servers like Next.js, etc...Before submitting the PR, please make sure you do the following
fixes #123
).