Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of scSTEM repo #2

Open
marouenbg opened this issue Oct 7, 2021 · 3 comments
Open

Review of scSTEM repo #2

marouenbg opened this issue Oct 7, 2021 · 3 comments

Comments

@marouenbg
Copy link

Overall, it is very easy to install scSTEM using the first option and run it, it is very accessible.
I have a few minor comments:

  • it would be nice to abstract a few steps by the command line, for example: the download of lock file could be done through a command like curl -O file.lock
  • Also, you can specify the example path only once in the beginning as a variable for example path <- 'home/alex/sctem' and then refer to that variable for the remainder of the tutorial.
  • You can also include the installation of the trajectory inference software as a dependency
  • Finally, it would be nice to have an example button in the GUI that preloads some toy example data or even real world data.

Fantastic tool overall!

@alexQiSong
Copy link
Owner

Thanks for the comments, very helpful!

@marouenbg
Copy link
Author

For the second round, I suggest the following:

  • add releases to STEM, you can use GitHub release to add a microversion everytime you push new code/bug fix. For example, when the new GUI, this can be SCSTEM 0.1.1
  • In README
    install_folder = "/home/alex/scstem/"
    renv::restore(project = install_folder, lockfile = paste0(install_folder,"renv.lock"), prompt = F)
  • In README
    add a section on how to update scTEM if a new release is developed. That would be through
    1- devtools::install_github("alexQiSong/scSTEM", upgrade = "always") then 2-restart Rstudio.
  • In GUI, the infer trajectory button could use a more expressive icon than a folder, I am not sure how shiny works, but if this is possible you can use icons from https://fontawesome.com/

Great job developing this phenomenal tool @alexQiSong !

@alexQiSong
Copy link
Owner

alexQiSong commented Dec 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants