Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tipue search integration #193

Merged
merged 5 commits into from
Feb 7, 2020

Conversation

JackMcKew
Copy link
Contributor

Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page

Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page
@JackMcKew JackMcKew mentioned this pull request Dec 12, 2019
templates/base.html Show resolved Hide resolved
static/tipuesearch/tipuesearch_content.js Outdated Show resolved Hide resolved
templates/search.html Outdated Show resolved Hide resolved
templates/base.html Show resolved Hide resolved
@alexandrevicenzi alexandrevicenzi added this to the 2.3.0 milestone Jan 17, 2020
Copy link
Contributor Author

@JackMcKew JackMcKew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My apologies, this is my first ever 'real' pull request on github & web development in general. Thank you for taking the time to review these changes, it is greatly appreciated. I have tried to amend the changes as per the review. I am unsure how to implement translation if you could please direct me to where this is implemented elsewhere and I will amend.

@JackMcKew
Copy link
Contributor Author

Furthermore, please find an example of how the page loads at https://jackmckew.dev/search.html?q=test. Unsure if this is how you wish for the theme to look as per the CSS.

@alexandrevicenzi
Copy link
Owner

I noticed that tipue seach CSS overides some of this theme CSS, which is not good. It could be easily fixed if we customize tipue CSS.

@JackMcKew
Copy link
Contributor Author

Please find changes in latest commit to not override theme CSS, see below image for an example output with updated CSS

image

@JackMcKew
Copy link
Contributor Author

Live example at: https://jackmckew.dev/search.html?q=test

@alexandrevicenzi
Copy link
Owner

@JackMcKew thank you, that looks nice.

@alexandrevicenzi alexandrevicenzi merged commit fbe7d17 into alexandrevicenzi:master Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants