Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tipue search integration #193

Merged
merged 5 commits into from Feb 7, 2020
Merged

Conversation

@JackMcKew
Copy link
Contributor

JackMcKew commented Dec 12, 2019

Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page

Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page
@JackMcKew JackMcKew mentioned this pull request Dec 12, 2019
templates/base.html Show resolved Hide resolved
static/tipuesearch/tipuesearch_content.js Outdated Show resolved Hide resolved
templates/search.html Outdated Show resolved Hide resolved
templates/base.html Show resolved Hide resolved
@alexandrevicenzi alexandrevicenzi added this to the 2.3.0 milestone Jan 17, 2020
Copy link
Contributor Author

JackMcKew left a comment

My apologies, this is my first ever 'real' pull request on github & web development in general. Thank you for taking the time to review these changes, it is greatly appreciated. I have tried to amend the changes as per the review. I am unsure how to implement translation if you could please direct me to where this is implemented elsewhere and I will amend.

@JackMcKew

This comment has been minimized.

Copy link
Contributor Author

JackMcKew commented Jan 17, 2020

Furthermore, please find an example of how the page loads at https://jackmckew.dev/search.html?q=test. Unsure if this is how you wish for the theme to look as per the CSS.

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Jan 28, 2020

I noticed that tipue seach CSS overides some of this theme CSS, which is not good. It could be easily fixed if we customize tipue CSS.

@JackMcKew

This comment has been minimized.

Copy link
Contributor Author

JackMcKew commented Feb 3, 2020

Please find changes in latest commit to not override theme CSS, see below image for an example output with updated CSS

image

@JackMcKew

This comment has been minimized.

Copy link
Contributor Author

JackMcKew commented Feb 3, 2020

@alexandrevicenzi

This comment has been minimized.

Copy link
Owner

alexandrevicenzi commented Feb 7, 2020

@JackMcKew thank you, that looks nice.

@alexandrevicenzi alexandrevicenzi merged commit fbe7d17 into alexandrevicenzi:master Feb 7, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.