-
-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tipue search integration #193
Conversation
Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My apologies, this is my first ever 'real' pull request on github & web development in general. Thank you for taking the time to review these changes, it is greatly appreciated. I have tried to amend the changes as per the review. I am unsure how to implement translation if you could please direct me to where this is implemented elsewhere and I will amend.
Furthermore, please find an example of how the page loads at https://jackmckew.dev/search.html?q=test. Unsure if this is how you wish for the theme to look as per the CSS. |
I noticed that tipue seach CSS overides some of this theme CSS, which is not good. It could be easily fixed if we customize tipue CSS. |
Live example at: https://jackmckew.dev/search.html?q=test |
@JackMcKew thank you, that looks nice. |
Integrated tipue search plugin functionality (https://github.com/getpelican/pelican-plugins/tree/master/tipue_search), to use add USE_TIPUE_SEARCH = True to pelicanconf.py and optional search.html page