Disable SDL2 conversion of touch->mouse and mouse->touch on all platforms not just iOS/Android #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orms not just iOS/Android
Norfolc
reviewed
Jun 2, 2024
src/movie_lib.cc
Outdated
| @@ -99,7 +99,7 @@ static void _nfPkDecomp(unsigned char* buf, unsigned char* a2, int a3, int a4, i | |||
|
|
|||
| static constexpr uint16_t loadUInt16LE(const uint8_t* b); | |||
| static constexpr uint32_t loadUInt32LE(const uint8_t* b); | |||
| static uint8_t getOffset(uint16_t v); | |||
| static int getOffset(uint16_t v); | |||
There was a problem hiding this comment.
The change in this file seems to be related to the #188.
There was a problem hiding this comment.
Yes, I didn't realise that pushing an unrelated commit (for fixing the movies) on my fork's main branch would add it to this pull request. I should undo that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, SDL2 simulates mouse events from real touch input, and simulates touch events from real mouse input. This project doesn't require either of those, because it handles both touch and mouse inputs itself.
The existing code specifically disables both these simulation features when the platform is iOS, and also when the platform is Android. This likely covers most touchscreen gadgets being used, but when run on a different platform with a touchscreen (in my case, a Nintendo Switch running Linux), the touchscreen events are duplicated as simulated mouse events, leading to the mouse cursor jumping after a movement is finished, as I created an issue about.
I'm happy to be corrected if I'm wrong, but I can't see any downside to disabling these SDL2 features for all platforms, simulation of touch or mouse never being required because the game handles both. Let me know if anything needs improving, ty.