Add Olympus support #299
Add Olympus support #299
Conversation
| // arguments instead of tile. Original game (x86) does not distinguish | ||
| // between integers and pointers, so one of the tiles is silently ignored | ||
| // while calculating rotation. As a workaround this opcode now accepts | ||
| // both integers and objects. |
There was a problem hiding this comment.
Maybe the bug should be fixed in the script?) Sounds like a rabbit hole allowing such ambiguity in arguments. If it says tile num, it should be tile num IMO.
There was a problem hiding this comment.
Or maybe good to implement original game behavior - just ignore, maybe with warning
There was a problem hiding this comment.
I agree, keep the original behavior (only accept int) but write warning in the debug log. This is a really bad idea to try and hack the engine around bugs in scripts :)
|
Can we merge this PR? I would like to play Olympus using this project :) |
|
In theory, since we now have additional data type in scripts (object pointer), it allows for flexibility like this. However, I think better to reserve it for new opcodes to keep backwards compatibility (keep original behavior for vanilla opcodes). For opcode arguments that accept integer, you can just reinterpret pointer to integer and let it run, or (better) print error and return some default value. Bot do not interrupt the script flow. (this will solve the original issue, since vanilla behavior will be retained) |
A couple of last minute fixes for Olympus.