Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [REQUEST] iSponsorBlockTV: Same as CastSponsorSkip but with support for Youtube TV clients (so not limited to casting only). #1058

Open
2 tasks done
diamant-x opened this issue Nov 2, 2023 · 10 comments
Labels
enhancement New feature or request prevent stale Prevents stale being applied

Comments

@diamant-x
Copy link

Checked

  • If a new addon, I have checked on Google that such as addon doesn't already exists
  • If a new feature, I have searched in the discussions & issues that it was not already covered

Which addon?

iSponsorBlockTV

Is your feature request related to a problem? Please describe

Currently CastSponsorSkip is limited to only devices which are Casting youtube. This addons should in theory allow the same for youtube apps such as the ones in an Android TV or smartTVs.

Describe the solution you'd like

https://github.com/dmunozv04/iSponsorBlockTV/wiki/Installation

Thanks!

@diamant-x diamant-x added enhancement New feature or request prevent stale Prevents stale being applied labels Nov 2, 2023
@bruvv
Copy link
Contributor

bruvv commented Nov 12, 2023

Have you tried this: https://github.com/bertybuttface/addons/tree/main/isponsorblocktv ?

@diamant-x
Copy link
Author

Have you tried this: https://github.com/bertybuttface/addons/tree/main/isponsorblocktv ?

Didn't find it before! I'll take a look and let you know . Hopefully no need to duplicate it.
Thanks!

@bruvv
Copy link
Contributor

bruvv commented Nov 12, 2023

No worries, also be aware of https://github.com/yuliskov/SmartTube which you can side load on android tv things to have it natively. This isponserblocktv repo is python based and there for a bit more resource intensive than castsponserskip.

@diamant-x
Copy link
Author

At the moment I'm trying that one, with honestly good results, but I would prefer to have something compatible with the default app so it can scale across devices.

@gabe565
Copy link
Contributor

gabe565 commented Jan 25, 2024

Hello! CastSponsorSkip dev here. I wanted to chime in and mention that CastSponsorSkip seems to work fine for Google/Android TV. I have an NVIDIA Shield, and when I play a video on the YouTube app, it behaves as if the video was cast, even though I opened the app and played the video with the remote.

@diamant-x
Copy link
Author

diamant-x commented Jan 26, 2024

@gabe565

I tried that but the add-on won't detect my YouTube app in Nvidia shield (2017). With my Chromecast it just works fine. Do I need to create a YouTube API key or something? What about subnets?

2024/01/26 11:52:40 INFO CastSponsorSkip v0.7.0 (688f922)
2024/01/26 11:52:40 INFO Searching for devices...
2024/01/26 11:52:40 INFO Connected to cast device. device="Chromecast"

@diamant-x
Copy link
Author

@alexbelgium I'm trying to set some Environment variables for the CastSponsorSkip integration that aren't exposed in the UI. However, the addon_config folder for it is not created. I trie dmanually creating the folder and adding the config.yaml file as the others but the variables are not being picke dup https://github.com/alexbelgium/hassio-addons/wiki/Add%E2%80%90ons-feature-:-add-env-variables

Could you check if the config.yaml file is picked up for this one, or otherwise, add to the Addons UI the available parameters for the addon ? https://github.com/gabe565/CastSponsorSkip/blob/main/docs/castsponsorskip.md
In particular, I was trying to modify the CSS_DEVICES to manually reference my Nvidia Shield and test if it works, and CSS_LOG_LEVEL to troubleshoot it.

Thanks!

@gabe565
Copy link
Contributor

gabe565 commented Jan 30, 2024

I tried that but the add-on won't detect my YouTube app in Nvidia shield (2017). With my Chromecast it just works fine. Do I need to create a YouTube API key or something? What about subnets?

@diamant-x I'd love to help out but don't want this thread to get too off-topic. Would you mind posting this in gabe565/CastSponsorSkip#46?

Edit: I just read your second message, and CSS_DEVICES was exactly what I was going to suggest trying. I don't use this extension, so unfortunately I can't help with how to add extra envs

@alexbelgium
Copy link
Owner

Hello, I'll add the mapping of the config folder ; this should allow you to use indeed by embedded env injection system :-)

alexbelgium added a commit that referenced this issue Jan 30, 2024
@diamant-x
Copy link
Author

Hello, I'll add the mapping of the config folder ; this should allow you to use indeed by embedded env injection system :-)

Wow that was fast, thanks!!
config file now working. Will try some and open up a ticket in the other repo to avoid spamming this one, hopefully my original op is no longer needed if this already support native Android TV Youtybe app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request prevent stale Prevents stale being applied
Projects
None yet
Development

No branches or pull requests

4 participants