Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support OSX notifications as alternative to growl #40

Closed
wants to merge 1 commit into from

Conversation

RaVbaker
Copy link

I have coded the OSX Notifications support for rerun. It uses terminal-notifier gem. And you can use it with two different arguments: -on or --osx-notifications. If you will use it will disable the growl notifications.

Related to issue: #33

How it looks? See here: OS X notifications for rerun gem

@pvdb
Copy link

pvdb commented Aug 28, 2013

👍 / @alexch - can we please have it on master? 😄

@alexch
Copy link
Owner

alexch commented Mar 6, 2014

This looks great but I'm worried about adding a gem requirement for terminal-notifier in case people are on a different platform or a lower OS X version. Not sure how to do optional gems... :-(

@alexch
Copy link
Owner

alexch commented Mar 6, 2014

I suppose I could check for the terminal-notifier binary, like I check for growlnotify now, and ask the user to install it manually via gem or homebrew if they want it. (This is a developer tool after all!)

@jmuheim
Copy link

jmuheim commented Mar 19, 2014

Any news on this?

@alexch
Copy link
Owner

alexch commented Mar 19, 2014

I looked into it and I think a better approach would be to look for the
command line tool rather than the gem. Otherwise I might need to get into
building different rerun gems for different platforms... which is doable
but annoying. I did a bunch of work on rerun last week and I hope to get
some time this week to do more.

@jmuheim
Copy link

jmuheim commented Mar 19, 2014

This would be really nice. Maybe @RaVbaker could update his PR?

@jeromegn
Copy link

jeromegn commented Jun 7, 2014

👍

@alexch
Copy link
Owner

alexch commented Sep 22, 2015

starting work on this here: 5532e9b

@alexch
Copy link
Owner

alexch commented Sep 24, 2015

and finished here (mostly): 95a1eb1

@alexch alexch closed this Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants