Fix git-blame error on url missing .git #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @frk1705 for catching this. I'll pull it in and publish an update if you can add a quick unit test for this case. Please add a test to this file. |
|
Is one spec enough? |
|
One more to ensure that it works with a repo with dash in the name and we should be good. |
|
Btw, is there a reason that your .gitignore includes |
|
not sure will fix. i'll also remove the ignore except git-tools rule there. i had it as a submodule for a while. |
alexcorre
added a commit
that referenced
this pull request
May 29, 2014
Fix git-blame error on url missing .git
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can clone a git repo from urls without the
.gitat the end:git clone git@github.com:alexcorre/git-blameThis results in git-blame throwing an error on clicking the hash to open in browser:
This patch fixes that error.