Move PushRemoteElement to Rust #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcrichton
reviewed
Feb 7, 2018
| @@ -130,12 +143,12 @@ export class Context { | |||
| private encodeObject(a: any): number { | |||
| const idx = this.stack.length; | |||
| this.stack.push(a); | |||
| return this.encodeNumberAndTag(idx, Tag.ANY); | |||
| return this.encodeNumberAndTag(idx, Tag.ANY, isConst(a)); | |||
There was a problem hiding this comment.
Oh here I think you'll want to run through the generic encode method again with a.value(), right?
This relies on adding a new instruction, UpdateWithReference, to the instruction list.
tomdale
force-pushed
the
more-rust-const-ref-gbox
branch
from
c45d4d4
to
768acea
Compare
tomdale
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To move PushRemoteElement into Rust, this PR primarily introduces two new abstractions.
ConstReferences, we extend the GBox bitfield to add an additional bit for references that have aCONSTANT_TAGtag.UpdateWithReferenceinstruction toInstructionListthat takes a reference as the first op and generates aReferenceCacheas well as emitting an updating program opcode that asserts on the cached reference.