This repository was archived by the owner on Jan 16, 2023. It is now read-only.
Add shareProps property in Treebread. #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property will be passed on to every node element.
For example, you add an edit button on every node, when click this button, you want to invoke something like ()=>onEdit(props.node).
In that case, you would like to write like <Treebread shareProps={{onEdit:this.edit}} />. Then, in every node, you can use props.onEdit.
|
@TimYi Thanks. I'll review and write a test for this. I might change the prop name, but the concept is good. |
|
Hey guys, we are using react-treebeard, can this feature get implemented ? It would be really helpful |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This property will be passed on to every node element.
For example, you add an edit button on every node, when click this button, you want to invoke something like ()=>onEdit(props.node).
In that case, you would like to write like . Then, in every node, you can use props.onEdit.
Hi Alex, I readed the source code and used Treebread in my work. Really good work, abstract the function of a treeview apart from it's display very well.
I'm a backend programmer, and not familiar with front end tools. I learned webpack, npm and react a few days ago. So I know I should write some test, but it's not that easy for me to let it run.
I think it will work for I test this grammar in my project.