Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now it's possible for routes to be added to methods that will never be called. I happened to do this since the readme implicitly encouraged defining methods as strings, and I accidentally made a typo and saw that it wasn’t caught at runtime. This 3-line PR will identify the error and panic at route definition.
Thanks for writing this package, by the way – I'm learning how to develop web services in Go using your books and am considering using this router in a production setting since I expect my service won't be particularly CPU-bound and I enjoy the minimal-dependency life. :-)
Edit: Hmm, maybe the error message should say "invalid HTTP method" rather than "unsupported".
Edit 2: An alternative might be to change the example code to use
http.MethodGet
, which would make it impossible for this sort of typo to compile.