[pull] master from kubernetes-sigs:master #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
It was brought to my attention that the relationship between client.Object and runtime.Object isn't particularly clear to folks who are not used to working in the guts of client-go & apimachinery, so this adds some docs to helpfully clarify and provide examples.
📖 Improve docs for client.Object
Before this change, passing an `unstructured.UnstructuredList` to `client.List()` would erroneously delegate to the typed client, causing an error if the target type isn't registered with the client's scheme, violating the purpose of using `unstructured`. This patch fixes the client so that the `unstructured.UnstructuredList` is delegated to the internal unstructured client.
🐛 Fix use of `UnstructuredList` with unregistered typed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )