[pull] master from kubernetes-sigs:master #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
✨ Bump k8s dependencies to 1.20
Currently, when we create a new delegating client and we force some types to be uncached, we can only specify client.Object(s). When these objects are passed to the delegating client, and their GVK is matched against the internal map, the check doesn't take into account that the client might be issuing a List call with a ObjectList instead of a metav1.Object. The proposed solution is taken from the discovery rest mapper, which does the same ~hack. While it's not perfect, probably close to all generated objects are going to have a list that has the "List" suffix, that when removed gives back the original GVK. If there are other solutions, happy to change this hack. Signed-off-by: Vince Prignano <vincepri@vmware.com>
🐛 Cache bypass should take into account List types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )