-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds option to adjust the audio volume on a per podcast basis #8
Conversation
Hi @maltebaer Yes, the project uses poetry for package management. If a new dependency is consumed, it should be made available via e.g. |
On a quick test on my laptop (with the missing ffmpeg dependency), it looked like it was stuck during the download part. I think this might be because if (ep.volume_adjustment != 0):
adjusted_content = self.__adjust_volume__(r.content, ep.volume_adjustment)
else:
adjusted_content=r.content and that seemed to work. |
I updated the code to avoid potential issues with missing ffmpeg. I still get an error from the linter about |
try: | ||
# Safe to use untrusted input: executable is hardcoded | ||
# noqa: S603 | ||
executable = "ffmpeg" if platform.system().lower() != "windows" else "ffmpeg.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, nice that you considered platform-independent'ness! I was wondering if this works on Windows as well, as I noticed another user running this on a Windows host. Unfortunately, I have no option to test it on Windows...
Do you have a Windows setup where you could try it out already?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I can't try it either. To be honest, I only asked Chat GPT to make it Windows safe.
This is a great change. Thanks for contributing! I'm going to release this as a new |
As discussed in #7, this PR adds the ability to adjust the volume.
This is done using
pydub
, which in turn requiresffmpeg
. So I guess it is not a very lightweight solution.By the way, is there a method to list the required dependencies in a python project and install them all at once? Like with
npm
for Node.js projects?