Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make several type signatures more permissive of downstream Extra st… #162

Closed
wants to merge 2 commits into from
Closed

Make several type signatures more permissive of downstream Extra st… #162

wants to merge 2 commits into from

Conversation

aweinstock314
Copy link
Contributor

…ructs.

This was referenced Feb 21, 2023
Closed
Open
@alexheretic
Copy link
Owner

Thanks, i need to look at this more closely. One worry is the section default changes, since they look quite breaking. I wonder if there's a way to minimise that.

@alexheretic
Copy link
Owner

Yeah it doesn't seem too bad a break, but it's still a break.

I'd maybe like to remove some stuff for the next break too, like the legacy mod code. Maybe we should also remove the defaulting to Extra as I wonder if glyph_brush should have an opinion on that at all.

Perhaps we could (also) make a non-breaking version of this, where you maybe have to use with_text/with_extra method so it can be released earlier?

This was referenced Feb 21, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aweinstock314 @alexheretic