-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes - hopefully improvements - on the design of the Cube environment #214
Merged
alexhernandezgarcia
merged 55 commits into
cube-sep23-allornone-oldtest
from
cube-abstract-source
Sep 25, 2023
Merged
Changes - hopefully improvements - on the design of the Cube environment #214
alexhernandezgarcia
merged 55 commits into
cube-sep23-allornone-oldtest
from
cube-abstract-source
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents from source.
…_variance although it is not used.
alexhernandezgarcia
requested review from
michalkoziarski and
AlexandraVolokhova
September 20, 2023 15:24
…stead of logits and the actual alpha and beta that will go in the Beta policy
michalkoziarski
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, I added some minor comments.
…ponents) and effective with the corners proxy.
…rt of the distr params dictionaries.
This was referenced Sep 23, 2023
…d set lightweight default values.
…meters because backward sampling is broken.
alexhernandezgarcia
merged commit Sep 25, 2023
419c9c8
into
cube-sep23-allornone-oldtest
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cube design
max_val
and simply hard code it to 1.0. There is no clear reason to have this additional complexity..isclose
.Code improvement
epsilon
in the environment to control the boundaries for clamping the inputs tolog_prob
.Test data set
epsilon
in the generation of the grid and uniform data sets. The tests I have run show that including states with dimensions equal or too close to the boundaries has an impact on the logprobs-based metrics. See wandb report.Fixes
fixed_distribution
in some config files was outdated and has been changed to the currentfixed_distr_params
Other
_get_beta_params_from_mean_variance()
which is eventually not used. But I have chosen to leave it for potential future use. Please excuse me the sacrilege.