-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript Type Aliases #13
Conversation
(WIP) Things that need to be completed
|
… language specific features
… typescript features
What's left in this PR is solving a new bug that has appeared after adding type aliases, where hephaestus can not correctly recognize subtyping relations (ie. trying to assign a boolean to a number). |
Type Aliases are ready to go! For more information on the issue described on my previous message, please read this. A similar issue was encountered and fixed while developing the Union Types feature. After adding complete support for TypeScript's Structural Typing system and Union Types, we will proceed with adding both Union Types as candidates for Type Aliases (should be trivial after adding support for these features). Keep an eye out for the progress on that update in the Union Types pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
Please also add unit tests for checking that the subtyping relations of the TypeAlias
, StringLiteralType
, and NumberLiteralType
types work as expected.
This should be ready to merge after pushing the required unit tests. |
This is still a WIP. Opened PR for status reports and discussion on the progress of this feature since GitHub does not allow to reference already existing branches in Issues (#8).