remove deprecated usage of Attr.nodeName and use Attr.name instead #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Attr.nodeName is now deprecated (see https://developer.mozilla.org/en-US/docs/Web/API/Attr#Deprecated_properties_and_methods)
In practice, I needed that so that I can run green-turtle in node.js through jsdom (A JavaScript implementation of the DOM, for use with node.js).
With that patch the following seem to work fine with JSDOM
There are probably other little things to patch so that things work properly but I can keep appending them to this PR if you are OK to merge those.
Otherwise, it would be nice to give green-turtle a package.json and make it available to NPM. Some refactoring would have to happen to restructure the files in their own modules but a lot of the code could be used in Node.js (or as standalone functions).
In particular it would be nice to use something like https://github.com/scienceai/get-dom to provide a DOM.
I am happy to help if that's something that you are willing to merge.
Thanks!