Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added chapter on sets #362

Closed
wants to merge 1 commit into from

Conversation

AndrewPluzhnikov
Copy link
Contributor

Hello,

I wrote a chapter introducing sets.

Please let me know if you'd like me to change or add anything.

@alexmojaki
Copy link
Owner

Hello,

Thank you for being willing to contribute to futurecoder! It's always great to have new contributors. I'm also very impressed that you learned how course content is implemented and wrote a whole chapter, that looks like a lot of work.

Unfortunately I don't think I can use this right now. I see several issues with how this is written. I don't want to list them all, but one example is that it uses many concepts that haven't been taught elsewhere in the course, such as:

  • Multiple arguments to range and print
  • Tuples
  • Comments
  • Imports
  • Formatting

I mentioned in https://github.com/alexmojaki/futurecoder/blob/master/how_to_contribute.md#helping-with-course-content that I prefer for people to make a proposal draft in markdown before trying to implement anything. Maybe I should add some extra clarity/emphasis to that point. It's not just that implementing content is technically tricky. I also don't want people to go through the effort of implementing course content too soon, to prevent this kind of thing. I'm sorry that wasn't clear.

But there's a bright side! Since you've learned how to implement course content, you can help with #363. Adding a chapter on dicts is a much higher priority than sets. The content is already written, it just needs to be implemented. I was procrastinating doing that myself and didn't expect that anyone else would be able to, so having help would be great. Are you interested?

@AndrewPluzhnikov
Copy link
Contributor Author

Alex,
I'd like to go ahead and implement the chapter on dictionaries.
I will comment on the other issue(#363) with some questions.

@alexmojaki alexmojaki closed this Jul 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants