Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass source to template separatedly. #62

Merged
merged 2 commits into from
Feb 24, 2021
Merged

Pass source to template separatedly. #62

merged 2 commits into from
Feb 24, 2021

Conversation

voxik
Copy link
Contributor

@voxik voxik commented Sep 15, 2020

This fixes compatibility with ActionView 6.0.0+, whic deprecated old style template handlers [1].

Fixes #61.

@voxik
Pass source to template separatedly.
42ab912 
This fixes compatibility with ActionView 6.0.0+, whic deprecated old
style template handlers [[1]].

Fixes alexrothenberg#61.

[1]: rails/rails#35119
@voxik voxik mentioned this pull request Sep 15, 2020
Closed
@alexrothenberg
Copy link
Owner

@voxik Thank you so much for this pull. I merged a very similar change in #63 so this issue should be resolved. I'll try to release a version onto rubygems shortly.

@alexrothenberg alexrothenberg merged commit a3ccc6e into alexrothenberg:master Feb 24, 2021
@alexrothenberg
Copy link
Owner

@voxik on second thought I like your fix even better so merged it in. Thanks again 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rails 6 support?
2 participants
@voxik @alexrothenberg