Notification enhancement #31

auricgoldfinger · 2016-09-07T19:04:03Z

Description

Enhanced the notifications for birthdays:

In case of only one birthday, show the name and the age
In case of multiple birthdays:
- If the notification is collapsed, keep the original behaviour except for the number of events (right bottom of notification) which now displays the number of birthdays
- If the notification is expanded, show the name of each person and their age

Test(s) added

no. Frankly I don't know how I could test this 😄

Screenshots

In case of only one birthday

In case of multiple birthdays:
Collapsed

Expanded

auricgoldfinger · 2016-09-07T19:36:08Z

Oh btw. Today is not my birthday.

alexstyl · 2016-09-07T20:30:45Z

mobile/src/main/java/com/alexstyl/specialdates/util/Notifier.java

                .setContentIntent(intent)
+                .setNumber(events.getContactCount())


This is done right before displaying the notification (https://github.com/alexstyl/Memento-Namedays/pull/31/files#diff-a57d0b3fb13451a13012ab3380f979cfR155) so it is going to be overridden eventually.

Can you remove the later one and keep yours as part of this PR please?

alexstyl · 2016-09-07T20:42:02Z

This looks great! I have added some comments in the PR that needs fixing.

Don't worry about the testing. The class was written a couple of years ago when I didn't really know how to structure my code properly for testing, so it definitely needs work on my end 💃

alexstyl · 2016-09-07T20:48:55Z

mobile/src/main/res/values/strings.xml

@@ -19,6 +19,7 @@
    <string name="today_celebrates_one">%1$s</string>
    <string name="today_celebrates_two">%1$s and %2$s</string>
    <string name="today_celebrates_many">%1$s and %2$d others</string>
+    <string name="age_today">%1$s   %2$d today</string>


The app uses a "Turns X" (see string "turns_age") when communicating birthdays with age to the user.
Instead of using a new string, I would prefer if you use the existing one instead and add the name of the contact programmatically.

- remove second .setNumber() on builder - remove final keyword - use turn_age in stead of new age_today

auricgoldfinger · 2016-09-08T08:06:07Z

So I applied your remarks and now the notification looks like this

alexstyl · 2016-09-08T09:03:07Z

mobile/src/main/java/com/alexstyl/specialdates/util/Notifier.java

+
+                String lineFormatted = name;
+
+                if (EventType.BIRTHDAY.equals(event.getType())) {


❌ This is hard to extend. What happens when more events are added in the future? We would have to check all bits of code that do checks with specific events.

Also, a Birthday might not include a year of birth, which means that the following bit will throw an exception if the contact does not have a specified year of birth.

You could just copy-paste the getLabelFor() method. It checks only for that special case, and fallbacks to using the label of the eventType if there is no special case.

Don't worry about the code duplication from the other class. I'll solve it nicely in a later PR :)

Copy Paste! Oh no!
...
Well, ok then. I'm not yet familiar enough with your code so I'm going to leave such a refactoring up to you. Let me add a big TODO and deprecated so that it can be found later.

I'm going to create an issue as well so that it is not forgotten

alexstyl · 2016-09-08T09:05:05Z

Just one more comment and we are good to go 💯

Also, please update the PR description with the updated screenshot

alexstyl · 2016-09-08T09:05:45Z

mobile/src/main/java/com/alexstyl/specialdates/util/Notifier.java

@@ -114,8 +167,6 @@ public void forDailyReminder(ContactEvents events) {
            builder.setPublicVersion(publicNotification.build());
        }

-        builder.setNumber(contactCount);


alexstyl · 2016-09-08T09:23:39Z

😱 Don't create commit messages like that! They are not informative of what is going on at all

The first commits messages you did were great 😄

auricgoldfinger · 2016-09-08T09:26:54Z

I know. But the information is there when you click the ...
Git commit guidelines say the short descriptions must be only 50 characters long and I couldn't find a short description that contained all the changes 😃

Event labels are centralized this way. Fallback will make sure new events will be handled automatically + check whether birthday includes a year to avoid NPE's This method is copy-pased from ContactEventView and must be refactored.

alexstyl · 2016-09-08T09:38:25Z

Good point, but not everyone is going through the history through Github ;)
Then again, I don't mention anything in the How to contribute section so jokes on me 😛

An alternative is to have one commit per change so that you can actually checkout the specific change at any time.

alexstyl · 2016-09-08T09:39:01Z

mobile/src/main/java/com/alexstyl/specialdates/util/Notifier.java

@@ -188,6 +179,27 @@ public void forDailyReminder(ContactEvents events) {

    }

+    /**
+     * TODO duplicated from {@link com.alexstyl.specialdates.upcoming.ui.ContactEventView#getLabelFor(ContactEvent)}


auricgoldfinger · 2016-09-08T09:41:22Z

Yeah indeed. In this case, that would have been a better idea. I have to get used to checking in very small changes though. I'm used to SVN and try to avoid too many small commits. But Git works better that way I guess...

:-)

alexstyl · 2016-09-08T09:59:43Z

Thanks for the contribution. It is going to be included in the next update of the app 💯

Notification enhancement

auricgoldfinger added 3 commits September 7, 2016 17:06

Add inbox style + contact age

c895d25

Add number of birthdays

95d13f2

Removed debug code

31d07c6

alexstyl reviewed Sep 7, 2016
View reviewed changes

Fix @alexstyl remarks

3d9388b

- remove second .setNumber() on builder - remove final keyword - use turn_age in stead of new age_today

alexstyl reviewed Sep 8, 2016
View reviewed changes

Get event label using a separate method

f496039

Event labels are centralized this way. Fallback will make sure new events will be handled automatically + check whether birthday includes a year to avoid NPE's This method is copy-pased from ContactEventView and must be refactored.

alexstyl reviewed Sep 8, 2016
View reviewed changes

Use getLabelFor in case of a single event as well

77498ad

:-)

auricgoldfinger mentioned this pull request Sep 8, 2016

Code duplication in Notifier #33

Closed

alexstyl added this to the Exposed Search milestone Sep 8, 2016

alexstyl merged commit dc80bd5 into alexstyl:develop Sep 8, 2016

auricgoldfinger deleted the notification-enhancement branch September 8, 2016 10:04

alexstyl mentioned this pull request Sep 18, 2016

Release 4.0 (58) #46

Merged

alexstyl added a commit that referenced this pull request Jul 4, 2020

Merge pull request #31 from auricgoldfinger/notification-enhancement

c34f552

Notification enhancement

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Notification enhancement #31

Notification enhancement #31

auricgoldfinger commented Sep 7, 2016 •

edited

Loading

auricgoldfinger commented Sep 7, 2016

alexstyl Sep 7, 2016

alexstyl commented Sep 7, 2016

alexstyl Sep 7, 2016 •

edited

Loading

auricgoldfinger commented Sep 8, 2016 •

edited

Loading

alexstyl Sep 8, 2016 •

edited

Loading

auricgoldfinger Sep 8, 2016 •

edited

Loading

alexstyl commented Sep 8, 2016

alexstyl Sep 8, 2016

alexstyl commented Sep 8, 2016

auricgoldfinger commented Sep 8, 2016 •

edited

Loading

alexstyl commented Sep 8, 2016

alexstyl Sep 8, 2016

auricgoldfinger commented Sep 8, 2016

alexstyl commented Sep 8, 2016 •

edited

Loading

		.setContentIntent(intent)
		.setNumber(events.getContactCount())


		String lineFormatted = name;

		if (EventType.BIRTHDAY.equals(event.getType())) {

Notification enhancement #31

Notification enhancement #31

Conversation

auricgoldfinger commented Sep 7, 2016 • edited Loading

Description

Test(s) added

Screenshots

auricgoldfinger commented Sep 7, 2016

alexstyl Sep 7, 2016

Choose a reason for hiding this comment

alexstyl commented Sep 7, 2016

alexstyl Sep 7, 2016 • edited Loading

Choose a reason for hiding this comment

auricgoldfinger commented Sep 8, 2016 • edited Loading

alexstyl Sep 8, 2016 • edited Loading

Choose a reason for hiding this comment

auricgoldfinger Sep 8, 2016 • edited Loading

Choose a reason for hiding this comment

alexstyl commented Sep 8, 2016

alexstyl Sep 8, 2016

Choose a reason for hiding this comment

alexstyl commented Sep 8, 2016

auricgoldfinger commented Sep 8, 2016 • edited Loading

alexstyl commented Sep 8, 2016

alexstyl Sep 8, 2016

Choose a reason for hiding this comment

auricgoldfinger commented Sep 8, 2016

alexstyl commented Sep 8, 2016 • edited Loading

auricgoldfinger commented Sep 7, 2016 •

edited

Loading

alexstyl Sep 7, 2016 •

edited

Loading

auricgoldfinger commented Sep 8, 2016 •

edited

Loading

alexstyl Sep 8, 2016 •

edited

Loading

auricgoldfinger Sep 8, 2016 •

edited

Loading

auricgoldfinger commented Sep 8, 2016 •

edited

Loading

alexstyl commented Sep 8, 2016 •

edited

Loading