-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embedding thumbnails in mp3 fails #188
Comments
I believe that 'writethumbnail' means to save thumbnails as a separate file. If you are trying to use an embedded thumbnail, maybe you need to consider after downloading event. |
Ok - opened this one: yt-dlp/yt-dlp#5287 One question though before closing this issue: I managed to add the |
just put 'verbose' to ytdl_options like btw, there is a postprocessor named embedtumbnail so i think it should be like (not tested)
|
Just curious, did you ever figure this one out? I've tried every option I know to try with no luck. Even with using "postprocessors", I still get the error saying:
I'm trying to download this as an MP3 but even the download won't start. What gives? |
The output in the linked issue is what I get when adding the verbose flag. It does not output the actual yt-dlp command which is executed. Any other idea how to get it in order to progress debugging? |
looks you want download a video which not provide mp3 format. |
metube uses the embedded youtubedl.py but not the binary yt-dlp. Of course the output is different. |
I have this same behaviour on a clean build, I can bypass it by removing lines 69-71 in this file: https://github.com/alexta69/metube/blob/master/app/dl_formats.py#L70 I haven't found a way to workaround with overrides yet, verbose logging of the failure is here:
|
very good try. I think we need to convert the thumbnail to jpg (not png) before embedding in mp3 (png works fine in mp4 video but not mp3 |
Hey that's an idea, I will try adding this before line 69
|
Yep, that solved it here, I reckon there are a few other issues that also reference this |
convert thumbnail to jpg before embed #188
Hello! Sorry to re-open this issue, but I am having trouble making this work. I can successfully download thumbnails as webp files and embed them into my MP4 video files. The embedded thumbnail shows up on my file explorer, however I am using Jellyfin for my media and it does not support webp files for thumbnails and therefore does not display thumbnails correctly. This is the what I was using for the YTDL Options - {"writeautomaticsub":true,"subtitleslangs":["en","-live_chat"],"writethumbnail":true,"updatetime":false,"postprocessors":[{"key":"Exec","exec_cmd":"chmod 0664","when":"after_move"},{"key":"FFmpegEmbedSubtitle","already_have_subtitle":false},{"key":"FFmpegMetadata","add_chapters":true},{"key":"EmbedThumbnail"}]} This again downloads thumbnails as webp files and embeds them successfully. However, I need to convert the webp files into jgp before embedding. Here are various YTDL Options I have tried to no avail: {"writeautomaticsub":true,"subtitleslangs":["en","-live_chat"],"writethumbnail":true,"updatetime":false,"postprocessors":[{"key":"Exec","exec_cmd":"chmod 0664","when":"after_move"},{"key":"FFmpegThumbnailsConvertor","format":"jpg"},"key":"FFmpegEmbedSubtitle","already_have_subtitle":false},{"key":"FFmpegMetadata","add_chapters":true},{"key":"EmbedThumbnail"}]} {"writeautomaticsub":true,"subtitleslangs":["en","-live_chat"],"writethumbnail":true,"updatetime":false,"postprocessors":[{"key":"Exec","exec_cmd":"chmod 0664","when":"after_move"},{"key":"FFmpegThumbnailsConvertor","format":"jpg", "when": "before_dl"},"key":"FFmpegEmbedSubtitle","already_have_subtitle":false},{"key":"FFmpegMetadata","add_chapters":true},{"key":"EmbedThumbnail"}]} Due to the nature of my homelab setup (I am using TrueNAS Scale with a truecharts install of metube) only have access to change the Output Template, YTDL Options, and an option to add Extra Environment Variables and Extra Args, see below. I prefer to only edit the YTDL Options rather than add Extra Environment Variables or Extra Args, but I am happy to try it if someone has an idea of what I can do to make the webp to jpg conversion successful. Thanks in advance for your help! |
I'll get a png thumbnail when download a video from youtube. can you provide an example? |
Thank you for your reply, when downloading this youtube video https://youtu.be/TTsi4Kg6hkQ?si=YhDa8IOTzoFnRbES for example as an MP4, with my set YTDL options, it will download the thumbnail as a webp while downloading the video, then once the video is downloaded, will embed the webp thumbnail into the mp4 and delete the webp. |
still works for me my options:
|
Hi and thanks for your software.
I made a minimum install of the docker image without any changes.
I am trying to download mp3 from YT videos. With the default option it is attempted to embed the thumbnails but it fails with the following error. The item is then listed as "failed" in the list but the download folder actually contains the mp3 + the webp image as seperate files. Video ID used for testing: xI6dqImaQ50
ERROR: Postprocessing: Stream #0:0: Video: png, rgb24(pc, gbr/unknown/unknown, progressive), 1280x720, q=2-31, 200 kb/s, -nan fps,
How can I fix the thumbnail creation to work correctly with mp3 so that I end up only with an mp3 file in the download directory and the items are shown as completed in the list?
To work around this I also tried to start with
YTDL_OPTIONS={"writethumbnail":false}
But that setting seems to be ignored or does not apply in this case because it's the same result as described above.
The text was updated successfully, but these errors were encountered: