Add opposite checking steps part2 #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added steps for entering random numbers (alfa-laboratory#60)
fork update
| * без учёта порядка элементов | ||
| */ | ||
| @SuppressWarnings("unchecked") | ||
| @Тогда("^список \"([^\"]*)\" со страницы не совпадает со списком \"([^\"]*)\"$") |
There was a problem hiding this comment.
кажется это не очень конкретный шаг. если хотя бы по одному элементу произойдет не совпадение - шаг пройдет и будет не понятно, это корректное поведение или нет. проверками того, что список соответствует ожидаемому или содержит/не содержит элемент можно покрыть все нужные кейсы
| * Проверка, что поле редактируемо | ||
| */ | ||
| @Тогда("^(?:поле|элемент) \"([^\"]*)\" (?:доступно|доступен) для редактирования$") | ||
| public void fieldIsEnabled(String elementName) { |
There was a problem hiding this comment.
излишне. когда в поле вводится значение неявно происходит проверка того, что оно редактируемо. соответственно, поле можно и желательно проверять введя туда тест и проверив, что он отобразился как ожидалось.
snfrolov
added a commit
to snfrolov/akita
that referenced
this pull request
May 25, 2018
Add opposite checking steps part2 (alfa-laboratory#68)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.