Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker #3

Closed
baruchiro opened this issue Apr 23, 2020 · 10 comments · Fixed by #12
Closed

Docker #3

baruchiro opened this issue Apr 23, 2020 · 10 comments · Fixed by #12

Comments

@baruchiro
Copy link
Contributor

We need to put this deamon in Docker Image and publish it with Github Actions

@baruchiro
Copy link
Contributor Author

So I created a Dockerfile in #9.

But I have a problem, related to the two-factor authentication situation. The TelegramClient constructor request us to insert our phone number in the console, and then insert the security code we received from Telegram.

This authentication not required after the first time I run the script, so I need to do research about that, if and how we can solve this problem.

@mitto98
Copy link

mitto98 commented Apr 23, 2020

I've created the repository (https://hub.docker.com/repository/docker/mitto98/telegram-download-daemon), let me know when you have finished, so I can build and push it.

@baruchiro
Copy link
Contributor Author

@mitto98 I think you actually publish the image now, but you can see in the comment above that I have a problem.

Also, I will want to create a Github Action for CD the image, so when I will implement that, you will need to share a secret or something with @alfem

@baruchiro
Copy link
Contributor Author

I don't have a Telegram experience, and I have very little experience with Docker, so I went to a gamification solution: https://stackoverflow.com/questions/61395907/telethon-telegramclient-authentication-in-docker-container

When you give points to people, they will want to answer you even if your project is not in their best interest.

@alfem
Copy link
Owner

alfem commented Apr 24, 2020

I wonder why the question in stackoverflow had -1 points. I have given it +1.

I also wonder why are you so interested in this script, but that is another issue :-D

@baruchiro
Copy link
Contributor Author

Thanks @alfem !

I'm interesting this script because I want to create a docker-composr for my home-server.

I'm thinking about docker for Plex, and I need another docker for downloading content to the Plex folder. And because I often get content to watch from Telegram, I'm looking for a way to download automatically.

@baruchiro
Copy link
Contributor Author

baruchiro commented May 8, 2020

Hi @alfem , currently I'm using the docker from my fork, with a GitHub Docker Registry.

I don't like to work with forks, of course I think all the forks should update the original repo for keep it updated with all problems solved in the forks.

But if you feel I'm moving too fast, that's fine.

I just want to say that I will continue to maintain my fork, and you will have to see if I have solved any problems there, you will need to merge them to this repo.

Also I think I will create my own image in DockerHub

@alfem
Copy link
Owner

alfem commented May 9, 2020

Thanks for asking!
I had a severe failure in my laptop and got it fixed a couple of days ago (new hd, new motherboard...).

I am fine with your fork, as I trust your work with the docker issues. Just remember to throw me a pull request when it got ready.

@baruchiro
Copy link
Contributor Author

Pull Request #9 is about this issue.

@alfem
Copy link
Owner

alfem commented May 9, 2020

Oops, I see. I thought you were still working out the auth mechanism.

Please, check my comments in #9 and I will merge it ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants