Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tfdt box #90

Merged
merged 3 commits into from
Jan 12, 2023
Merged

Feature/tfdt box #90

merged 3 commits into from
Jan 12, 2023

Conversation

jensenn
Copy link
Contributor

@jensenn jensenn commented Jan 11, 2023

This PR adds the tfdt box which is necessary for isobmff files

@alfg
Copy link
Owner

alfg commented Jan 11, 2023

Thank you! Will take a look and test this soon.

@jensenn
Copy link
Contributor Author

jensenn commented Jan 11, 2023

There will likely be another PR for better handling of track fragments. Currently the track functions, sample_offset(), sample_time() and sample_rendering_offset() need some work to better handle track fragments.

I'm also thinking about a good way to handle parsing track fragments if they are from different readers. I am currently using a custom struct that is a cross between io::Cursor and io::Chain as my reader. Perhaps adding a read_fragment(&mut self) function to Mp4Reader.

Again, the end goal is parsing isobmff mp4s that may have the init separate from track fragments.

@alfg alfg merged commit 9c0f653 into alfg:master Jan 12, 2023
@alfg
Copy link
Owner

alfg commented Jan 12, 2023

Sounds good. Thank you!

jprochazk pushed a commit to jprochazk/mp4 that referenced this pull request Sep 18, 2024
* Add Tfdt box parsing

* Derive Default for TfdtBox

* Derive Eq for TfdtBox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants