Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove the need of an api map key #637

Closed
syjer opened this issue May 4, 2019 · 1 comment
Closed

remove the need of an api map key #637

syjer opened this issue May 4, 2019 · 1 comment
Assignees
@syjer
Labels
enhancement
Milestone
2.0-M2

Comments

@syjer
Copy link
Member

syjer commented May 4, 2019

Sometimes the location is not needed.
@syjer syjer added this to the 2.0-M2 milestone May 4, 2019
@syjer syjer self-assigned this May 4, 2019
syjer added a commit that referenced this issue May 5, 2019
@syjer
#637 map api key: expose the 'NONE' choice + ui tweak in setting view
74ecebe
syjer added a commit that referenced this issue May 5, 2019
@syjer
#637 set lat/long as nullable, change validation
ef56d6b
syjer added a commit that referenced this issue May 5, 2019
@syjer
#637 handle public website
4f0f8be
syjer added a commit that referenced this issue May 5, 2019
@syjer
#637 fix test
6b22c51
@syjer syjer mentioned this issue May 5, 2019
Merged
cbellone pushed a commit that referenced this issue May 5, 2019
@syjer @cbellone
implement #637 remove map api key mandatory check (#639)
d640280 
* #637 map api key: expose the 'NONE' choice + ui tweak in setting view

* #637 set lat/long as nullable, change validation

* #637 handle public website

* #637 fix test
@cbellone cbellone closed this as completed May 5, 2019
@cbellone
Copy link
Member

cbellone commented May 5, 2019

implemented

@cbellone cbellone mentioned this issue May 5, 2019
Merged
syjer added a commit that referenced this issue May 6, 2019
@syjer
#637 fix update event header handling with geolocation
8b0e702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syjer syjer

Labels
enhancement
Projects
None yet
Milestone
2.0-M2
Development

No branches or pull requests
2 participants
@syjer @cbellone